test(parser): unskip parse_unexpected_do and parse_unexpected_rbrace#866
Merged
test(parser): unskip parse_unexpected_do and parse_unexpected_rbrace#866
Conversation
These two parse error tests now pass — the parser correctly rejects unexpected 'do' and '}' keywords at top level.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove
### skipfrom two parse error tests that now pass.Why
After scanning all 25 skipped spec tests, these two now pass:
parse_unexpected_do— parser correctly rejects unexpecteddooutside a loopparse_unexpected_rbrace— parser correctly rejects unexpected}at top levelAll other 23 skipped tests still fail and remain skipped.
Tests
Pass rate: 100% (1783 passed, 0 failed, 23 skipped — up from 1781 passed, 25 skipped)